Skip to content

feat: add priority option #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

feat: add priority option #205

merged 1 commit into from
Mar 3, 2025

Conversation

@Sakib25800
Copy link
Member

@Sakib25800 Sakib25800 commented Feb 27, 2025

This PR adds a priority option to @bors r=<username> <p=priority> and @bors r+ <p=priority>.

@Sakib25800
Copy link
Member Author

Sakib25800 commented Feb 27, 2025

Prerequisite to #202

Kobzol
Kobzol reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Left some comments. And there should also be some tests (e.g. run @bors r+ p=... twice in a row and similar cases).

Then we'll add more test cases once @bors p=5 is implemented.

@Sakib25800
Copy link
Member Author

Sakib25800 commented Mar 1, 2025

Thanks! I'll make those changes and @ you when ready.

@Sakib25800
Copy link
Member Author

Sakib25800 commented Mar 1, 2025 •
edited
Loading

@Kobzol do we need a max_priority option like Homu has?

Kobzol
Kobzol reviewed Mar 2, 2025
View reviewed changes
Sakib25800
Sakib25800 commented Mar 2, 2025
View reviewed changes
@Kobzol
Copy link
Member

Kobzol commented Mar 2, 2025

@Kobzol do we need a max_priority option like Homu has?

I don't think so, I haven't ever seen it being useful/used anywhere.

@Kobzol Kobzol mentioned this pull request Mar 2, 2025
Open
Kobzol
Kobzol reviewed Mar 2, 2025
View reviewed changes
@Sakib25800 Sakib25800 force-pushed the feat/add-priority-parameter branch 2 times, most recently from af8114d to e13c8a0 Compare March 2, 2025 12:42
@Sakib25800
Copy link
Member Author

Sakib25800 commented Mar 2, 2025 •
edited
Loading

If there's any further changes needed, lmk.

Kobzol
Kobzol reviewed Mar 2, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add two following tests:

  • User sets priority with @bors p=X, and then does @bors r+, and check that the priority is still X.
  • User sets priority with @bors p=X, and then does @bors r+ p=Y, and check that the priority is now Y.

Then I think we're done here :)

@Sakib25800 Sakib25800 force-pushed the feat/add-priority-parameter branch from e13c8a0 to 7ce5c06 Compare March 2, 2025 23:45
@Sakib25800
Copy link
Member Author

Sakib25800 commented Mar 2, 2025

Added priority_preserved_after_approve and priority_overridden_on_approve_with_priority 🫡.

@Sakib25800 Sakib25800 force-pushed the feat/add-priority-parameter branch from 7ce5c06 to cd516a4 Compare March 2, 2025 23:48
Kobzol
Kobzol approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is really impressive work.

@Kobzol Kobzol added this pull request to the merge queue Mar 3, 2025
Merged via the queue into rust-lang:main with commit 3b95f4d Mar 3, 2025
2 checks passed
@Kobzol Kobzol mentioned this pull request Mar 11, 2025
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sakib25800 @Kobzol